search

drdoctr / doctr

A tool for automatically deploying docs from Travis CI to GitHub pages.
https://drdoctr.github.io
MIT License
107 stars 30 forks source link

TRAVIS_TAG could set canpush without checking all rules #347

Open peterjc opened 5 years ago

peterjc commented 5 years ago

If $TRAVIS_TAG and --build-tags are set, then we get canpush=True without checking all rules, e.g. If the repository was a fork, then the push should be prevented.

As an aside, I noticed this edge can while looking at issue #342 (there are legitimate cases where it is reasonable to want to push from a forked repository).

asmeurer commented 5 years ago

Looks like the doctr tests don't even pass on fork builds. I need to finish https://github.com/drdoctr/doctr/pull/343.

asmeurer commented 5 years ago

Oh actually I think that test failure is legitimate. It's a test for this function. So it should be updated.

I think I never considered the fact that someone would push a tag to their fork, but this looks correct.