drdoctr / doctr

A tool for automatically deploying docs from Travis CI to GitHub pages.
https://drdoctr.github.io
MIT License
107 stars 30 forks source link

Support new authentication for GitHub #369

Closed asmeurer closed 3 years ago

asmeurer commented 4 years ago

Our GitHub authentication method is deprecated and will go away in November. See https://github.blog/2020-07-30-token-authentication-requirements-for-api-and-git-operations/ and https://twitter.com/patricktoomey/status/1289019204662972419. The simplest way is to have people generate a token, although we should try to do the localhost callback or device authorization flow if we can.

peterjc commented 4 years ago

Tokens provided via a TravisCI protected environment variable work well, see #349 - sadly I have not made time to finish that.

asmeurer commented 4 years ago

This is about doctr configure. As far as I know, the behavior of doctr deploy should continue to work as it currently is.

asmeurer commented 4 years ago

So GitHub has dropped support. doctr configure now fails with invalid username or password even if you enter the correct password.