search

dre1080 / warden

More than just a user database auth package for FuelPHP
http://dre1080.github.com/warden
MIT License
46 stars 11 forks source link

Fixed the logic on is_confirm() and is_lock_expired(), they were the reve #11

Closed JesseObrien closed 13 years ago

JesseObrien commented 13 years ago

Fixed the logic on is_confirm() and is_lock_expired(), they were the reverse of what they should be. When I registered a brand new user with confirmable turned off in the config, and using the default lock time from the class it first threw an error saying "confirmable_token" property not found.

After switching the logic there, it told me the account was locked upon first authentication.

I tested it by calling lock_access() on the newly created user after fixing this logic.

JesseObrien commented 13 years ago

These were fixed with https://github.com/dre1080/warden/commit/c95358ecace78a454239645299d39fecc2931b15

dre1080 commented 13 years ago

The issue was still happening, found the problem was actually in Model_User::is_lock_expired() logic and Model_User::is_attempts_exceeded() fixed here https://github.com/dre1080/warden/commit/3b6b76838c7530b4b77af41dd991e75479342afb

thanks