dre2901 / node-red-contrib-myq

Node-Red node to control MyQ (Chamberlain) devices
5 stars 3 forks source link

Newest version generating: ERR_REQUIRE_ESM #11

Closed rgerrans closed 10 months ago

rgerrans commented 10 months ago

Just updated to the newest version and getting the error ERR_REQUIRE_ESM

dbeinke commented 10 months ago

I am having the same issues

k5map commented 10 months ago

I'm using this node to monitor my garage door and gate... each time I send an INFO request, I get the current status but also get a lot of "Error received:" and "Count not refresh devices!" in the debug message area

rgerrans commented 10 months ago

I rolled back to the previous version and it appears to be working fine

On Tue, Sep 5, 2023, 8:01 PM Mike @.***> wrote:

I'm using this node to monitor my garage door and gate... each time I send an INFO request, I get the current status but also get a lot of "Error received:" and "Count not refresh devices!" in the debug message area

— Reply to this email directly, view it on GitHub https://github.com/dre2901/node-red-contrib-myq/issues/11#issuecomment-1707537267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOC2HGJHLFKGKQWXYYO7PTXY7KPFANCNFSM6AAAAAA4I4J5NA . You are receiving this because you authored the thread.Message ID: @.***>

k5map commented 10 months ago

I never upgraded and am running v0.0.6... @rgerrans, after downgrading are you getting any errors on INFO request?

k5map commented 10 months ago

Looks like the issue is with the updated dependency of "@hjdhjd/myq": "7.4.2"... prior to that I believe it was 6.0.6

dbeinke commented 10 months ago

what version did you roll back too? I tried 0.0.6 and got nothing at all and 0.0.5 unidentified error return from service

Further research shows that the dependency switch to esm only back at version 7 https://github.com/hjdhjd/myq/blob/main/docs/Changelog.md

rgerrans commented 10 months ago

npm install @.***

On Wed, Sep 6, 2023, 6:10 AM dbeinke @.***> wrote:

okay so how do I roll back?

— Reply to this email directly, view it on GitHub https://github.com/dre2901/node-red-contrib-myq/issues/11#issuecomment-1708226989, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOC2HCWWVWYFEQ2XK3RT6LXZBR2DANCNFSM6AAAAAA4I4J5NA . You are receiving this because you were mentioned.Message ID: @.***>

rgerrans commented 10 months ago

I take that back. I'm getting errors with v0.0.6

On Wed, Sep 6, 2023 at 7:56 AM Ron Gerrans @.***> wrote:

npm install @.***

On Wed, Sep 6, 2023, 6:10 AM dbeinke @.***> wrote:

okay so how do I roll back?

— Reply to this email directly, view it on GitHub https://github.com/dre2901/node-red-contrib-myq/issues/11#issuecomment-1708226989, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOC2HCWWVWYFEQ2XK3RT6LXZBR2DANCNFSM6AAAAAA4I4J5NA . You are receiving this because you were mentioned.Message ID: @.***>

hitnrun30 commented 10 months ago

Same here, I was having issues with it working so I saw that there was an update and it made things worse

rgerrans commented 10 months ago

Unfortunately at this point I uninstalled it and 🤞 for an update. I can't install 3.1 due to another node that won't work with that, so not sure if 0.0.7 will work with the new version of Node-Red w/o the error.

On Fri, Sep 8, 2023 at 8:20 AM hitnrun30 @.***> wrote:

Same here, I was having issues with it working so I saw that there was an update and it made things worse

— Reply to this email directly, view it on GitHub https://github.com/dre2901/node-red-contrib-myq/issues/11#issuecomment-1711751091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOC2HEW3XLK47CFOV45PVTXZMSTZANCNFSM6AAAAAA4I4J5NA . You are receiving this because you were mentioned.Message ID: @.***>

dre2901 commented 10 months ago

Downgraded it to "@hjdhjd/myq": "6.0.9" but it does raise same authentication errors. The reason is the changed API endpoints which now require regional suffix '-east' or '-west' (for example, 'https://partner-identity-east.myq-cloud.com/connect/authorize' instead of simply 'https://partner-identity.myq-cloud.com/connect/authorize' as it is now). This change is only supported in myq > 7.1.0 but since it was also then require ES modules and node > 18, then it might not work in node-red :( . Will have to fork and patch the version 6..

rgerrans commented 10 months ago

Great, thanks. I'm running Node v18, I assume I just need to add ES through npm then?

dre2901 commented 10 months ago

My Raspi is not on v18 and it's not easy to upgrade it unfortunately, so I will stick with an older one ;) Just released 0.0.9 with patched version of myq and support of region on configuration screen. Per default, 'east' is selected. Works on my side without any errors in console. So fingers crossed they will not come up with some more endpoint changes

k5map commented 10 months ago

@dre2901 ... much thanks for getting this fixed. Would it be possible to include the ability to report status of "opening, closing and stopped"? I have a MyQ gate and garage door opener. Both generate "undefined" errors when they are in those states.

dre2901 commented 10 months ago

opening/closing errors were fixed in 0.0.10 (was a trivial bug)