search

dreadl0ck / ja3

Go package for Ja3 TLS client and server hello fingerprints
BSD 3-Clause "New" or "Revised" License
144 stars 21 forks source link

Proposal: Please start using Semantic Versioning #5

Closed KateGo520 closed 4 years ago

KateGo520 commented 4 years ago

I found that this project already supports Go modules. But sadly, the tags doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it. 

$go get github.com/dreadl0ck/ja3@v1.0
go get github.com/dreadl0ck/ja3@v1.0: no matching versions for query "v1.0"
$go get github.com/dreadl0ck/ja3
go: downloading github.com/dreadl0ck/ja3 v0.0.0-20200304222813-39f4a089559b
go: github.com/dreadl0ck/ja3 upgrade => v0.0.0-20200304222813-39f4a089559b

Else the mod file shows something like github.com/dreadl0ck/ja3 v0.0.0-20200304222813-39f4a089559b which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control.

So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc, so that other project can use tag in go.mod.

KateGo520 commented 4 years ago

@dreadl0ck Could you help me review this issue? Thx :p

dreadl0ck commented 4 years ago

Hi there,

thanks for the heads up, will make a new release :)

dreadl0ck commented 4 years ago

There you go: https://github.com/dreadl0ck/ja3/releases/tag/v1.0.0

Let me know if that works for you!

KateGo520 commented 4 years ago

@dreadl0ck Yes. It works well now! 

$go get github.com/dreadl0ck/ja3
go: github.com/dreadl0ck/ja3 upgrade => v1.0.0
go: downloading github.com/dreadl0ck/ja3 v1.0.0

Thank you for your contribution!

dreadl0ck commented 4 years ago

Awesome, glad to help!