dream11 / kong-scalable-rate-limiter

Kong plugin for Rate Limiting at high throughputs.
https://dream11.github.io/kong-scalable-rate-limiter/
MIT License
40 stars 10 forks source link

Kong Plugin Feature Parity #13

Open TimUnderhay opened 2 years ago

TimUnderhay commented 2 years ago

Summary

Thanks for the work on this plugin. I suppose this is both a question and a feature request. Comparing the docs and code of this vs the native rate limiting plugin, I notice that the below config features are not present in this plugin. Are there plans to sync the functionality?

The official Kong plugin docs say "You can combine consumer.id, service.id, or route.id in the same request, to further narrow the scope of the plugin". I specifically need the ability to target both a consumer.id and a service.id simultaneously. Is this planned?

Thanks in advance!

chirag-manwani commented 2 years ago

Hi @KensingtonTech this is a genuine feature request and we would definitely want to add it to the plugin. Could you come up with a rough plan of what changes would be required for this? A PR would be highly welcome.

TimUnderhay commented 2 years ago

@chirag-manwani Apologies, I wasn't volunteering to take the lead on it. I was just asking if it was planned.

chirag-manwani commented 2 years ago

No worries. I will update here once we plan to implement it.