dream11 / kong-scalable-rate-limiter

Kong plugin for Rate Limiting at high throughputs.

https://dream11.github.io/kong-scalable-rate-limiter/

MIT License

40 stars 10 forks source link

Support auth enabled redis-cluster, consumer based routing, client rate limiting headers #16

Open chaitanya14 opened 1 year ago

chaitanya14 commented 1 year ago

Summary

Added functionality to support authentication enabled redis-cluster, consumer based routing and rate-limiting client headers.

Full changelog

Auth enabled redis-cluster.
Consumer based routing.
Rate-limiting client headers.
Added unit tests for schema validation
Added integration tests for consumer based routing and rate limiting client headers.

Issues resolved

15

jeremyjpj0916 commented 1 year ago

Nice to see yah implemented what we were discussing earlier in the day. That should do the trick in terms of what the redis client needs, but only thing not sure of is the nil case if the client will do anything whacky on connection but looks like it checks for it being a string and nil would keep it out of trying to use any kinda auth.

chaitanya14 commented 1 year ago

Pongo tests results:

chirag-manwani commented 1 year ago

@chaitanya14 Can you split this into multiple PRs each with its own set of tests? That would be easier to track and manage. You can add 3 PRs one for each of the following features- Auth enabled redis-cluster. Consumer based routing. Rate-limiting client headers.

chirag-manwani commented 1 year ago

@chaitanya14 For easier review can you please split the PR into multiple PRs as explained above?