dreamRs / apexcharter

:bar_chart: R Htmlwidget for ApexCharts.js
https://dreamrs.github.io/apexcharter
Other
138 stars 15 forks source link

ap(..., type = "timeline") not working #37

Open meersel opened 3 years ago

meersel commented 3 years ago

HI ApexCharter Team,

The type = "timeline" option is not working. No output (read: plot) is displayed.

I have sued the example from Github (see below):

library(apexcharter) library(tidyverse)

data("presidential", package = "ggplot2")

Basic

apex(presidential, mapping = aes(x = name, start = start, end = end), type = "timeline")

pvictor commented 3 years ago

Thanks for reporting it! That's fixed on GitHub version.

Victor

meersel commented 3 years ago

HI Victor,

Many thanks for the quick response. Timeline works now okay

Apexchaeter is a great package. My “ggplot” for interactive charts.

Apexcharter with R Crosstalk in the pipeline ?

Met vriendelijke groet,

Miguel

From: Victor Perriermailto:notifications@github.com Sent: Wednesday, December 16, 2020 10:40 AM To: dreamRs/apexchartermailto:apexcharter@noreply.github.com Cc: Miguel Eerselmailto:m.eersel@outlook.com; Authormailto:author@noreply.github.com Subject: Re: [dreamRs/apexcharter] ap(..., type = "timeline") not working (#37)

Thanks for reporting it! That's fixed on GitHub version.

Victor

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FdreamRs%2Fapexcharter%2Fissues%2F37%23issuecomment-746297806&data=04%7C01%7C%7Cb5cf67021b124fb98ebf08d8a1c82ccc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637437228403852962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DkyVrIYtciNVa7%2FWkM5LhIWEzq0O%2BsTm5rFwrLXeUcc%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHGET45GMG2X23AVYMD7LFDSVC2FNANCNFSM4U56FCHQ&data=04%7C01%7C%7Cb5cf67021b124fb98ebf08d8a1c82ccc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637437228403852962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FFG6GSnNUSML0hJrr%2FJ113PSCPCvXqiKIFvLMeoo%2Bwg%3D&reserved=0.

meersel commented 3 years ago

tiimeline is now working.

Another bug: Timeline plot disappears completely if both legends (Democrat and Republican) are deselected.

See R code below for the plot

With groups

With groups but force position

apex(presidential, aes(x = name, start = start, end = end, group = party), "timeline") %>% ax_xaxis(categories = presidential$name)

pvictor commented 3 years ago

I'm afraid that is a bad example, the bug is caused by using categories on x-axis which is apparently not expected...