search

dreamRs / datamods

Shiny modules to import and manipulate data into an application or addin
https://dreamrs.github.io/datamods/
GNU General Public License v3.0
138 stars 35 forks source link

incorrect reading of txt files (removes rows with an empty value automatically) #30

Closed dannyvolkaerts closed 2 years ago

dannyvolkaerts commented 3 years ago

When using datamods feature in esquisse (importing data) esquisse automatically removes rows with empty values instead of assigning NA values to them. I have experienced this with txt files. It shows the correct code after importing (and so admitting it has deleted the rows with empty values for a certain column). Try yourself importing the attached file -> code after importing file: Pokemon_dataset.txt %>% filter(!(Type2 %in% "")) Pokemon_dataset.txt

R version: 4.0.0 Esquisse version: 1.0.2.9000

FYI: this is not the case when reading the txt file in R with readr package and saving it as Rdata file. Then missing values are handled as expected (indication of 52% missing values for 'type2' without auto filtering it)

pvictor commented 3 years ago

Thanks for reporting this, I see 2 problems:

mbauwens commented 2 years ago

has this issue already been followed up/resolved? I've experienced the same problems as @dannyvolkaerts

pvictor commented 2 years ago

Can you share the data with which there is a problem @mbauwens ?

mbauwens commented 2 years ago

I've upgraded to R 4.0.5 and Esquisse 1.0.0 since and the issue has been resolved, probably from release v0.2.3 :)

pvictor commented 2 years ago

Thanks for checking @mbauwens :+1: