prevent encoding bug + disable_filters bug ?

[bthieurmel]

Hi Victor,

Same problem as previous merge request, but with better treatment. Some others case crashed with the previous patch... If data have some bad encoding like this example in line 3 :

CTP_ID_YEAR             CTP_NAME   Type2

1: 2011 MUSTASAARIN KAUPUNKI Finland 2: 2015 KALMAR KOMMUN Sweden 3: 2015 SKELLEFTE KOMMUN Sweden 4: 2015 VAXJO KOMMUN Sweden 5: 2008 MJOLBY KOMMUN Sweden 6: 2008 ARE KOMMUN Sweden create_filters using trimws crash and so the module / app "ll be dead ! So I propose this really quick fix. Not sur it's the best but it's work...

Moreover, it's seems there is some bug with disable_filters :

• options not passing from esquisser to esquisserUI
• without filter (disable_filters = TRUE), not data !

I 've just write a (really) quick working patch....

Benoit

[codecov-io]

Codecov Report

Merging #103 into master will decrease coverage by 0.13%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage      52%   51.86%   -0.14%     
==========================================
  Files          26       26              
  Lines        2348     2354       +6     
==========================================
  Hits         1221     1221              
- Misses       1127     1133       +6

Impacted Files	Coverage Δ
R/module-filterDF.R	55.76% <33.33%> (-0.85%)	:arrow_down:
R/module-chartControls.R	54.37% <0%> (-0.26%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f20ffca...398f5ac. Read the comment docs.

[pvictor]

Thanks!