search

dreamRs / esquisse

RStudio add-in to make plots interactively with ggplot2
https://dreamrs.github.io/esquisse
Other
1.77k stars 229 forks source link

check if data is null #110

Closed trafficonese closed 4 years ago

trafficonese commented 4 years ago

Opening the Select a dataset modal and closing it again without selecting a dataset, crashed the app when one of the variables is dragged into the x/y/fill,... fields.

This PR includes a small check if the dataset is NULL and shows a warning notification. Maybe it would make sense to remove the variables instead, if no dataset is selected, then this error should not happen.

codecov-io commented 4 years ago

Codecov Report

Merging #110 into master will decrease coverage by 0.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   52.16%   52.08%   -0.09%     
==========================================
  Files          26       26              
  Lines        2398     2402       +4     
==========================================
  Hits         1251     1251              
- Misses       1147     1151       +4
Impacted Files Coverage Δ
R/esquisserServer.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20a87c0...69475e4. Read the comment docs.

pvictor commented 4 years ago

Thanks!

Yes I use your suggestion and cleared choices (moved your code in observe above)

Victor