search

dreamRs / esquisse

RStudio add-in to make plots interactively with ggplot2
https://dreamrs.github.io/esquisse
Other
1.77k stars 229 forks source link

Prevent some encoding crash...? #99

Closed bthieurmel closed 4 years ago

bthieurmel commented 4 years ago

Hi Victor,

If data have some bad encoding like this example in line 3 : 

    CTP_ID_YEAR             CTP_NAME   Type2
 1:        2011 MUSTASAARIN KAUPUNKI Finland
 2:        2015        KALMAR KOMMUN  Sweden
 3:        2015 SKELLEFTE<c5> KOMMUN  Sweden
 4:        2015         VAXJO KOMMUN  Sweden
 5:        2008        MJOLBY KOMMUN  Sweden
 6:        2008           ARE KOMMUN  Sweden

create_filters using trimws crash and so the module / app "ll be dead ! So I propose this really quick fix. Not sur it's the best but it's work...

Benoit

codecov-io commented 4 years ago

Codecov Report

Merging #99 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage      52%    52%           
=====================================
  Files          26     26           
  Lines        2348   2348           
=====================================
  Hits         1221   1221           
  Misses       1127   1127
Impacted Files Coverage Δ
R/module-filterDF.R 56.6% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cd015c...f20ffca. Read the comment docs.

pvictor commented 4 years ago

Hello Benoît, Thanks, if that does the trick, that's fine for now.

Victor