search

dreamRs / fresh

Fresh shiny themes
https://dreamrs.github.io/fresh/
GNU General Public License v3.0
224 stars 10 forks source link

Clicked button color is not changed even if corresponding status color is changed #13

Closed paulimer closed 2 years ago

paulimer commented 2 years ago

Hi all, I have an issue in bs4dash, using fresh: if I change the secondary color, using 

bs4dash_status(secondary = "#009982")

for instance, the button (the ones with status = "secondary" obviously) color on hover looks correct, but not the clicked color, which is still a kind of grey, leftover from the initial secondary color I think.

I have searched the search_vars_bs4dash("button"), looking for a customizable variable, in vain.

By the way, thanks for this package, it is very useful!

pvictor commented 2 years ago

Ah yes I see that with CRAN version, with Github version it looks fine. Can you try ? Install from GitHub with : 

remotes::install_github("dreamRs/fresh")

Theres's no variable for the clicked state (called "active" in code), and it cannot be changed, value is darken($background, 10%), see here : https://github.com/dreamRs/fresh/blob/master/inst/assets/bootstrap-4.5.2/mixins/_buttons.scss

paulimer commented 2 years ago

I can confirm it does work with the Github version!

pvictor commented 2 years ago

Nice! If it's needed I can push an update on CRAN soon.

paulimer commented 2 years ago

It is not pressing at all, and I can use the github version just as well I think. Thanks again!