search

dreamRs / shinyWidgets

shinyWidgets : Extend widgets available in shiny
https://dreamrs.github.io/shinyWidgets/
GNU General Public License v3.0
833 stars 153 forks source link

Fix for onServerSearch inside virtualSelectInput #665

Closed MichalLauer closed 9 months ago

MichalLauer commented 9 months ago

This PR fixes issue mentioned in #664.

I did not use eval(...) as suggested because I found on the internet that it might cause security issues. Because of that, I chose the window[...] approach. One notable drawback of this implementation is that the functions that will be used (passed in the onServerSearch parameter) must be defined outside of any document.ready statement. I also updated the docs, NEWS.md and version.

Sorry if the news/version update is overboard - feel free to fix it or LMK and I'll create a new PR :)

Thanks!

MichalLauer commented 9 months ago

Scratch that, I will create a more general solution for the only two parameters that have this issue (onServerSearch, labelRenderer).