search

dreamRs / shinybusy

Minimal busy indicator for Shiny apps
https://dreamrs.github.io/shinybusy/
Other
138 stars 16 forks source link

shinybusy::show_modal_spinner() breaks app UI #22

Open WouterDH-UZL opened 2 years ago

WouterDH-UZL commented 2 years ago

The function show_modal_spinner() calls shinybusy:::html_dependency_spinkit() which adds "spinkit/spin.min.css" to your Shiny app. Inside that CSS file is the following line of code:

.shiny-bound-output { position: relative; }

This forces all .shiny-bound-output objects into a relative position, which breaks the layout of several of my UI outputs. Is such a sweeping change throughout the app really necessary for show_modal_spinner() to function?

pvictor commented 2 years ago

Yes you're right, that's unnecessary here, I removed it.

Victor