search

dreamRs / shinypop

Collection of notifications, confirm dialogs and alerts for 'Shiny' applications
GNU General Public License v3.0
51 stars 7 forks source link

Include functions for notiflix loading? #5

Closed danhalligan closed 5 months ago

danhalligan commented 6 months ago

The Notiflix JS library also contains functions to display loading indicators.

Would you be interested in including this functionality within this package? If so, would you accept a pull request to implement?

I made a proof of concept, minimal working version here: https://github.com/danhalligan/shinypop

pvictor commented 6 months ago

Hi, It's indeed a cool feature, nice addition, a PR will be great. But to let you know, I have no intention of publishing this package on CRAN, it will stay on GitHub. If you want something available on CRAN, you can look at adding it to package shinybusy where I also use Notiflix JS library.

danhalligan commented 5 months ago

I'll close this issue and try and implement in shinybusy. Cheers!