search

dreamcat4 / skippy-xd

A full-screen Exposé-style standalone task switcher for X11.
GNU General Public License v2.0
100 stars 12 forks source link

set window to focus on cancel outside of guard #154

Closed felixfung closed 1 year ago

felixfung commented 1 year ago

In https://github.com/dreamcat4/skippy-xd/commit/65b8e854c32d168e410c12fa5a1ae9c2b871b862, we set mw->clientwin_focus_on_cancel within if(ps->o.focus_initial && iter). If skippy is evoked with --expose or --paging, ps->o.focus_inital is not set, and mw->clientwin_focus_on_cancel is not set.

Here we set the variable before the if guard.

@dreamcat4 can you please review? Also in the future when you make changes, you can also create PRs, then I can help take a look :)

dreamcat4 commented 1 year ago

Thank you for that. Indeed is a better code. (and save of another bug). Was reviewed on code-bases only but seems fine. All looks great, merged.