dreamcat4 / skippy-xd

A full-screen Exposé-style standalone task switcher for X11.
GNU General Public License v2.0
99 stars 12 forks source link

necessary to improve these variable names: keysReverseDirection and modifierKeyMasksReverseDirection #167

Open dreamcat4 opened 1 year ago

dreamcat4 commented 1 year ago

I don't have any specific preference. However 1 suggestion is:

However any other preferred / better names is entirely accepted. Whatever anybody else feels is the best renaming.

The question of whether these legacy code / functionality should or not be deprecated is: entirely another matter!

So this issue is merely to decide some less confusing name(s). Of those existing keys. It's not to influence of affect any other type discussions around these wider keybindings feature sets / use cases.

*note:

That in xorg / x11 apis world, the term modifierKeyMask is in fact a different typed variable / entirely different entity to other representations of a modifier key. (for example, a modifier key itself, must by it's definition be either the Left Shift, or the Right Shift, but not both). Wheras a Shift modifier key mask then resolves to both left shift key and right shift key. So it is indeed a worthile to distinguish since the exact string value must be entered correctly (not to be ignored / broken setting, that is referring to other category of key symbols).

So this is why the variable was originally prefixed (begin with) the substring: modifierKeyMasks. To dis-ambiguate it from those other config lines, where you need to put other word(s).

If it's necessary to prefer the APIs nomenclature (as honest)... then consider the underscore instead. For example:

modifierKeyMasks_Reverse(s)NavigationDirection etc. etc.