felixfung
commented
1 year ago Your understanding is correct. In richardgv's code that was the behaviour, with no prev/next action. Subsequent commits added prev/next in place of left/right. This PR provides BOTH prev/next AND left/right.
I am working on a new PR to get the ordering of prev/next correct with respect to layout.
Documentation can come with future PR.
ok so if i understand correctly....
the distinction between these similar actions, it is that with prev/next, then the whole chain of windows is being traversed through (the linked list).
when next action is highlighting the right most window of a row, then it will move to the left most window of the subsequent row. like reading a book... and its wrapping back around to the top from the last bottom right entry to the top left very first entry.
but (the existing) up and down action is different, because it traverses vertically between the rows and (like on a spreadsheet) you get to the top or bottom row. and it cannot go further. it stops at the screen edge. and does not wrap back around.
so these new actions left and right should be similar equivalent in horizontal direction right? that is to say: they are doing like prev/next. except they do not wrap lines. they stop at the right of the screen. or the left edge of the screen.
i feel this could make sense, and is worthwhile to have this addition. however i just perhaps think we might try to explain / document the difference between such similar setting. so is clearer to other users who doesn't understand properly....
or maybe i didn't understand either! and got it wrong myself (but i hope not). come to think of it... there are also other existing settings options which are also maybe could benefit some extra documentation. to make clearer each setting purpose. so that is another possible way to improve skippy.
just so long as you can confirm here the purpose of the new setting, so we are clear. then happy to merge it.
you have also raised other pr(s), however i have been sick recently. and could not get around to them yet. to examine better those other pending work.... just - very glad to see recent efforts and activity on this project! it is a good work, and to acceptable standards / quality. i hope you find it rewardiing, a fulfilling type of coding. may it contine