dreamer / boxtron

Steam Play compatibility tool to run DOS games using native Linux DOSBox
https://luxtorpeda.gitlab.io/
GNU General Public License v2.0
405 stars 5 forks source link

Use XDG_DATA_DIRS to search for soundfonts #19

Closed gasinvein closed 5 years ago

gasinvein commented 5 years ago

Follow-up for discussion from https://github.com/dreamer/steam-dos/pull/18#discussion_r303206715.

gasinvein commented 5 years ago

Sorry for force-pushing, for some reason my local pycodestyle bahave differently from your CI, so I wanted to avoid purely-cosmetic commits.

dreamer commented 5 years ago

No worries, I can handle force pushes to private branch :)

CI is set up to use the latest versions of pylint, yapf, which might be newer than the ones provided by distribution; you can use pipenv to setup local virtual environment to use the newest versions:

$ pipenv install
$ pipenv shell
$ make lint
$ make test
$ make check-formatting

(I use pipenv only when CI indicates that something is wrong)

dreamer commented 5 years ago

Great change, thanks! :)