base container on ubuntu:trusty

dreamfactorysoftware / df-docker

Docker container for DreamFactory.

59 stars 56 forks source link

base container on ubuntu:trusty #17

Closed cjeffers closed 8 years ago

cjeffers commented 8 years ago

As per issue https://github.com/dreamfactorysoftware/df-docker/issues/16: Base container on ubuntu:trusty.

Other changes:

run chmod +x on docker-entrypoint.sh, because on Windows the permissions get nuked.
run composer update before running composer install I am very new to PHP and related tooling, so this may have issues that I'm unaware of, but it appeared to work fine on my machine.

todda48 commented 8 years ago

No need to run update and install. trusty added in another PR.

philicious commented 8 years ago

+1 for the chmod +x on docker-entrypoint.sh (its required and we also have this fix in our private copy. Forgot to bring it to the public fork / PR it.)

@cjeffers you wanna update your PR according to @todda48 comment or shall I do a new one ?

philicious commented 8 years ago

the chmod +x patch is also included in #23