fix for php mongodb driver extension

dreamfactorysoftware / df-docker

Docker container for DreamFactory.

59 stars 56 forks source link

fix for php mongodb driver extension #20

Closed philicious closed 8 years ago

philicious commented 8 years ago

fixes #16 #17 #19

this PR fixes the composer dependency errors introduced with the latest df-mongo changes to the mongodb driver

It also includes the fix for the base image. PR #17 is against develop branch which is behind master

philicious commented 8 years ago

@drewpearce is this repo still maintained? as it meanwhile suffers multiple flaws where each of it is sufficient to break the image fundamentally. Just asking to know if I should keep opening PRs or rather just maintain my fork and push my own (fixed/working) image to DockerHub

todda48 commented 8 years ago

Please make PRs on develop branch. Then we can do a release and it will be merged to master.

philicious commented 8 years ago

@todda48 ok. I can redo my PRs against develop. However I'm a bit confused as my other PR #15 got merged against master. So now and in the future I (we all) should PR against develop then ?

todda48 commented 8 years ago

Yeah, they should go to develop branch. #15 should have been for develop too. My mistake for merging it.

philicious commented 8 years ago

closed for #21