replaced sed delimiter with non valid base64 characters

dreamfactorysoftware / df-docker

Docker container for DreamFactory.

59 stars 56 forks source link

replaced sed delimiter with non valid base64 characters #46

Closed drewpearce closed 3 years ago

drewpearce commented 6 years ago

Laravel APP_KEY values are base64_encode strings. In base64 / is a valid output character. Therefore, if your your app key has a / in it, this sed command will fail and the container will not run properly, as it uses / for the delimiter. Replaced the / with @ as it is not a valid base64 output character and should not conflict with valid keys.

jacotri77 commented 6 years ago

Thanks, @drewpearce looking at incorporating this.

yaroslavmo commented 3 years ago

Closed by #87. Delimiters changed to '#'.