search

dreamingechoes / bootstrap_sb_admin_base_v1

Rails gem of the Bootstrap based admin theme SB Admin.
https://dreamingechoes.github.io/bootstrap_sb_admin_base_v1
MIT License
6 stars 3 forks source link

Require Bootstrap as a dependency and update assets #2

Closed neemiasvf closed 6 years ago

neemiasvf commented 6 years ago

Maintaining assets up-to-date may be difficult sometimes when you have a lot of them. To minimize this work,Bootstrap was added as a runtime dependency so that its most recent stable version is installed along with sb-admin. As for the other dependencies, the lack of an official maintained Rails gem makes it impossible to do the same. Therefore, those were updated to their latest version as of the date of this commit.

neemiasvf commented 6 years ago

Hi @dreamingechoes!

I really appreciate your work and I'd like to help you making a few improvements to it. I've noticed that Font Awesome and jQuery are included as a dependency so that their most recent version are installed. However, Bootstrap is not following the same logic. Since Bootstrap is the foundation of your theme, it's quite important to keep it updated. So I took the liberty to make it run as a dependency. I hope you like it. :)

dreamingechoes commented 6 years ago

Hi @neemiasvf!

Thank you for this contribution! 💖Let me review the pull request in order to check that all works properly, and as soon as I end the review, I'll merge this pull request 😄

Greetings!

dreamingechoes commented 6 years ago

Hi @neemiasvf!

Sorry for taking so long to review this pull request, the last couple of weeks I've been very busy at work. All looks good to me and seems to work fine, so I'll merge the pull request and I'll publish the new version of the gem!

Thank you again for this contribution! 🤗