search

dreamingtulpa / replicate-ruby

Replicate Ruby client
60 stars 6 forks source link

Relax Faraday version #6

Closed andreibondarev closed 1 year ago

andreibondarev commented 1 year ago

@dreamingtulpa For your review.

I'm working on integrating your gem into Langchain.rb but it won't install unless we relax the faraday gem version per this PR. Thank you!

andreibondarev commented 1 year ago

@dreamingtulpa For your review :)

dreamingtulpa commented 1 year ago

Hey Andrei. Thank you for the PR. I'm not sure if the gem is compatible with v1 of Faraday. Any reason you still relying on the old version?

andreibondarev commented 1 year ago

@dreamingtulpa The test suite passed when I ran it.

But there's a bunch of other gems that had the same problem.

dreamingtulpa commented 1 year ago

I took another look at it and it seems latest 1.x versions are indeed compatible. Added another test case to check faraday-multipart and it stays green. Your "relaxation" disables the use of 2.x though 😅 I now updated the dependency to >= 1.0 and bumped the gem. Should work now.

andreibondarev commented 1 year ago

@dreamingtulpa Thank you! I'll try it out!

andreibondarev commented 1 year ago

@dreamingtulpa Worked like a charm, thank you! https://github.com/andreibondarev/langchainrb/pull/44