IlCallo
commented
4 years ago Hi @soccer99, the package is still under development and some feature still hasn't been tested on SO different than Linux (I don't have a Mac so I cannot test on your system), that's why I added the "os": [ "linux" ] constraint to the package.json.
Especially paths management and Thumbor setup (they are currently writing the next major release and aren't answering any issue on their repo on this regard).
Feel free to:
- clone the repo
- setup Thumbor (if you want to use Art Direction)
- locally disable the OS constraint
- build the loader with
yarn build - locally reference the built loader (
yarn add file:./path/to/responsive-image-loader/) - check that everything works fine with mac :)
All needed info should be present into the CONTRIBUTING and DEV_ENVIRONMENT files (tel me if something is missing).
Note that currently there are some problems with tests (some race condition with Thumbor cache apparently) and they sometimes fail with Module build failed (from ../node_modules/raw-loader/dist/cjs.js): TypeError: Cannot read property 'replace' of undefined.
Re-execute tests 2-3 times will remove these errors. I'm deploying a new version with updated deps right now.
Related https://github.com/dreamonkey/responsive-image-loader/issues/3 https://github.com/dreamonkey/responsive-image-loader/issues/22
Describe the bug I cannot install this package on my Mac
npm install --save @dreamonkey/responsive-image-loader
npm ERR! code EBADPLATFORM npm ERR! notsup Unsupported platform for @dreamonkey/responsive-image-loader@0.3.1: wanted {"os":"linux","arch":"any"} (current: {"os":"darwin","arch":"x64"}) npm ERR! notsup Valid OS: linux npm ERR! notsup Valid Arch: any npm ERR! notsup Actual OS: darwin npm ERR! notsup Actual Arch: x64
To Reproduce Install using npm on mac
node v10.15.1 (npm v6.13.7)
Desktop (please complete the following information):