dreamos82 / DreamOs

A small 32 bit Operating system written from scratch
GNU General Public License v3.0
64 stars 16 forks source link

Bug fixed and added new script feature #21

Closed ghost closed 7 years ago

ghost commented 7 years ago
amanuel2 commented 7 years ago

I would recommend to start use #include and #include to get types like uint32_t etc... rather than use naked types such as unsigned int etc...

ghost commented 7 years ago

You are right, i know about this issue, i will have to discuss about this change with inuyasha

inuyasha82 commented 7 years ago

Some comments

  1. Don't put temporary code (look in task_utils.c, your comment contains a question, that it means that it is not discussed yet, in a pull request you should put only the code that are 100% ready to merge.
  2. Ideally a good practice is to create a pull request for every single feature implemented (if the new code add some bugs, it will be easied to identify and they are easier to read :) ), so in theory you should have created at least one pull request for the shell history, and one for the bochsconfig option.
ghost commented 7 years ago

Ok, single feature -> single pull request, i will remember this important rule for next pulls.

inuyasha82 commented 7 years ago

There is an issue in the history feature, if you go back to a specific command, and then delete the current selection using backspace, the command is deleted from the screen, but not deleted from the buffer, and if you press enter that command is still executed.

ghost commented 7 years ago

Strange, i cannot reproduce the bug. If i delete completely a command from history with backspace i got this:

root~:/root# root~:/root#

All seems to work