dreampiggy / AVIFQuickLook

AVIF QuickLook plugin on macOS
MIT License
170 stars 5 forks source link

After install via brew and qlmanage reload cache, the thumbnail updated, but become gray #15

Closed weaming closed 1 year ago

weaming commented 1 year ago
image image

first origin heif, second avif

dreampiggy commented 1 year ago

Seems the libavif render issue about HDR contents. Need dependency bump. I'll update next week.

weaming commented 1 year ago

any update ?

dreampiggy commented 1 year ago

@weaming Provide you sample AVIF to me, let me debug that

weaming commented 1 year ago

you can download from https://dl.bitsflow.org/example.avif

dreampiggy commented 1 year ago

Seems the code from SDWebImageAVIF, does not have the HDR contents support...It hardcode on 8bit sRGB only :)

Or maybe that YUV -> RGB conversion loss the Color Profile ?

SD is also maintained by me, but HDR content support will ship in next major release. I can patch to quickly support HDR by copying the code here😂

Fired issue: https://github.com/SDWebImage/SDWebImageAVIFCoder/issues/54

dreampiggy commented 1 year ago

16 should fix this issue.

@weaming Have a try with this new build (See readme about how to put that qlgenerator)

AVIFQuickLook.qlgenerator.zip

dreampiggy commented 1 year ago

image

weaming commented 1 year ago

works for me

dreampiggy commented 1 year ago

Ship with 1.2.0 version

dreampiggy commented 1 year ago

Homebrew and release page updated