dreamstalker / rehlds

Reverse-engineered HLDS
GNU General Public License v3.0
653 stars 167 forks source link

Minor changes and code refactor #942

Open GermanAizek opened 2 years ago

GermanAizek commented 2 years ago

@s1lentq hello, review PR changes and feedback me.

fred0r commented 1 year ago

been using this pr for some weeks now on linux with regamedll_cs and the hitboxes 'feel' much more 'accurate/natural' than before. the downside is that the hltv often gets disconnected with Dropped from x.x.x.x:27015 (Reliable channel overflowed). in my setup the server records every map played.

justgo97 commented 1 year ago

been using this pr for some weeks now on linux with regamedll_cs and the hitboxes 'feel' much more 'accurate/natural' than before. the downside is that the hltv often gets disconnected with Dropped from x.x.x.x:27015 (Reliable channel overflowed). in my setup the server records every map played.

The PR doesn't include any changes to how hitboxes function.

GermanAizek commented 1 year ago

@fred0r @justgo97 I had already forgotten about this PR, it turns out that someone else answered me. HLTV breakdown is possible due to delete operator or additional checks, I can divide this PR into two parts, where refactoring and where fixes.

GermanAizek commented 1 year ago

@justgo97 rehlds project is still active, are you doing it? In September, I created a PR, but no one answered it.

justgo97 commented 1 year ago

@justgo97 rehlds project is still active, are you doing it? In September, I created a PR, but no one answered it.

I'm not the project manager, I'm a normal user like you, I guess you can try to divide the PR to address one issue at a time, It will be easier to review and test the changes, no guarantee you will get an answer from the maintainers though.

GermanAizek commented 1 year ago

@s1lentq I accidentally made a force push. I hope you have pick up necessary fixes? Added new commit with fix minor memleak https://github.com/dreamstalker/rehlds/pull/942/commits/1fa34c2645006f2023c5b215010f8a7f19153986