dreamwhite / bugtracker

Bugtracker repository
GNU General Public License v3.0
1 stars 0 forks source link

Is the deletion of Misc/Entries possible as well? #20

Closed 5T33Z0 closed 2 years ago

5T33Z0 commented 2 years ago

Hi.

I looked into your script and noticed taht there's no option to automatically delete custom entries from the config.plist. I was thinking about somelthing like this:

def delete_misc_entries(self) -> None:
""" Deletes custom bootloader entries from config.plist"""
self.plist['Misc']['Entries']…??

But I don't know what to add after that to delete the entries. Since Misc/Entries are stores as Dictionaries it probably should delete any dict in that array, right?

dreamwhite commented 2 years ago

Hi, thank you so much for reaching me out. From what I tested, Misc/Entries is an array of dicts, so in case you wanna clear it you can just add self.plist['Misc']['Entries'] = []. Feel free to open a PR so I can keep track of changes easily

5T33Z0 commented 2 years ago

Thanks. It works.

dreamwhite commented 2 years ago

@5T33Z0 Since the same applies to Misc/BlessOverride can you open a PR that includes it? Thanks :D

5T33Z0 commented 2 years ago

I will create a fork and include the changes. But I would like to use a different name for the repo. Something more obvious like "OC Config Anonymizer" or "OC Config Defaultizer" or something. Is that ok for you?

dreamwhite commented 2 years ago

Well yeah, why not. I chosen this name for historical purposes (tldr: Catone was an ancient roman who introduced censorship to avoid spreading of Hellenic culture) but in case you wanna rename it something along the lines of OC-Anonymizer can fit

5T33Z0 commented 2 years ago

Interesting. Okay, cool. I only have to figure out how renaming a fork works

dreamwhite commented 2 years ago

I think I should rename it. Give me a few mins

dreamwhite commented 2 years ago

Done, let me know if it suits or not and eventually fork it again