search

dreamworksanimation / openmoonray

MoonRay is DreamWorks’ open-source, award-winning, state-of-the-art production MCRT renderer.
https://openmoonray.org/
Apache License 2.0
4.28k stars 248 forks source link

About the suffix ":shared" of volume option of docker container #81

Open junwha0511 opened 1 year ago

junwha0511 commented 1 year ago

Hi, first I'm really appreciate for opening this amazing project as open source.

I'm trying to follow the instruction for building MOONRAY using docker container, but found weird section.

docker run -v /source/openmoonray/building/ubuntu22.04:/building:shared  -v /optix:/optix:shared --network=host --rm -it openmoonray_base

The documentation gets me to add the suffix :shared at the end of the volume directory, but it shows an error that "[My directory] is mounted on /home but it is not a shared mount".

As I know, it is sufficient to use -v /source/openmoonray/building:/building

Is there any special purpose for the :shared keyword? I couldn't find any matching section from docker document.

Thank you.

rgwilson68 commented 1 year ago

There's no special purpose to :shared -- everything should work without this option

junwha0511 commented 1 year ago

Then isn't it better to remove that keyword from the document? it makes the error

vvzen commented 1 year ago

I stumbled into this error too when trying https://github.com/dreamworksanimation/openmoonray/issues/37#issuecomment-1484155809, if it's not really needed, I'd vote for removing it too!

junwha0511 commented 1 year ago

https://github.com/docker/docs/blob/main/storage/bind-mounts.md#configure-bind-propagation

This issue seems related to our problem https://github.com/docker/for-mac/issues/3431