Updates for Windows & Ar 2.0: ResolvedPath, Win drive letters

dreamworksanimation / usdmanager

USD Manager

http://www.usdmanager.org

Apache License 2.0

321 stars 60 forks source link

Updates for Windows & Ar 2.0: ResolvedPath, Win drive letters #29

Closed garyo closed 2 years ago

garyo commented 2 years ago

Windows links to drive-based files need three leading slashes
Ar 2.0 no longer has AnchorRelativePath; replace w/ CreateIdentifier
expandPath returns a ResolvedPath that needs to be converted to string before being passed to python in a couple of places

Signed-off-by: Gary Oberbrunner garyo@darkstarsystems.com

mds-dwa commented 2 years ago

Hi @garyo, can you please submit a signed contributor license agreement per this page when you get a chance so that we can proceed? Overall, the changes look good, but we'll need to test on this end once we get the green light from legal. Thank you for your contribution!

garyo commented 2 years ago

CLA submitted just now.

mds-dwa commented 2 years ago

Thank you! Once I get the OK from DWA, I’ll start testing internally.

mds-dwa commented 2 years ago

Just so you don't think this got lost in the ether, I was out on leave for a good while and one of our people that needs to approve this internally is likewise out for a bit longer, but I'll try to get it pushed through in the next few weeks. Apologies for the lengthy delay!

mds-dwa commented 2 years ago

I'm likely going to make some minor tweaks based on my above comments, but otherwise, this should be good to go. We'll be releasing a new 0.14 very soon.