search

dreamworksanimation / usdmanager

USD Manager
http://www.usdmanager.org
Apache License 2.0
321 stars 60 forks source link

PyQt vs. PySide QFontDialog.getFont difference #36

Open mdsandell opened 4 months ago

mdsandell commented 4 months ago

This fixes an issue with dragging tabs in PySide2 and python3 on Mac. Test by click-dragging any open tab. Drag/drop the tab on top of another tab in a second window to fully test the fix.

Traceback (most recent call last):
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/__init__.py", line 3865, in mouseMoveEvent
    mimeData.setData("action", "moveTab")
TypeError: 'PySide2.QtCore.QMimeData.setData' called with wrong argument types:
  PySide2.QtCore.QMimeData.setData(str, str)
Supported signatures:
  PySide2.QtCore.QMimeData.setData(str, PySide2.QtCore.QByteArray)

This also fixes a bug with font selection in the Preferences dialog in PySide1/2. This appears to be a difference between PyQt and PySide, returning font and ok in a different order. Test by going to Preferences and changing the font, watching for any terminal errors.

Traceback (most recent call last):
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/preferences_dialog.py", line 382, in selectFont
    self.updateFontLabel()
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/preferences_dialog.py", line 387, in updateFontLabel
    bold = "Bold " if self.docFont.bold() else ""
AttributeError: 'bool' object has no attribute 'bold'
tracypriest commented 4 months ago

@mdsandell Thanks for the update! It looks like we don't have a CLA for you. Could you sign the contributor agreement and email that to usdmanager@dreamworks.com?

Thanks a bunch!

mdsandell commented 4 months ago

Please find attached the individual contributor license agreement (page 2).

On Mon, Jul 8, 2024 at 4:03 PM tracypriest @.***> wrote:

@mdsandell https://github.com/mdsandell Thanks for the update! It looks like we don't have a CLA for you. Could you sign the contributor agreement http://www.usdmanager.org/USDManagerContributorLicenseAgreement.pdf and email that to @.***?

Thanks a bunch!

— Reply to this email directly, view it on GitHub https://github.com/dreamworksanimation/usdmanager/pull/36#issuecomment-2215492768, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZCFRFWBIVOD63FTBX6IRTZLMLC5AVCNFSM6AAAAABKMEOQW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJVGQ4TENZWHA . You are receiving this because you were mentioned.Message ID: @.***>