search

dreamyguy / gitlogg

💾 🧮 🤯 Parse the 'git log' of multiple repos to 'JSON'
MIT License
130 stars 27 forks source link

Refactor gitlogg.sh #14

Closed Inventitech closed 6 years ago

Inventitech commented 7 years ago

I have two ideas to improve gitlogg's code quality (bash part):

If you think this is helpful, I am more than happy to implement both these changes :-)

dreamyguy commented 7 years ago

@Inventitech feel free to rename gitlogg-generate-log.sh to gitlogg.sh. I kept it separated in case something else would turn out, but it never did. This has always been overkill.

Clarity around setup and process, which was my main concern, has become less painful with the setup script.

I'm fine with passing the path as an argument but would prefer that the environment variable would remain available as default (if there's no path argument, use the var). That way one can "set and forget".

I'll be more away on December, but will of course check for issues/PRs sporadically. 👍

Inventitech commented 7 years ago

Any progress on this? :)

dreamyguy commented 6 years ago

Right.. So I'm finally revisiting some projects. There's never enough time... ⌛️

I've decided to "discontinue" the bash implementation and focus on getting the javascript branch to a state where I can publish it as the main branch. That would overwrite this change, so there wouldn't be a point in merging it.

The only thing that kept me from merging it back then, when the PR was made, was that I would have to update the documentation. It required a very minor change but I couldn't prioritize even that.

Sometimes life takes over in overwhelming ways... 🌊