Closed cspotcode closed 6 years ago
This is looking like a fine piece of programming, @cspotcode! I'm eager to merge, but I haven't had the time to test yet.
I think from now on I'm going to accept pull-requests on dedicated branches, so that I can resolve conflicts, update the README file accordingly and do a proper release, so that documentation and functionality go hand in hand. Can you create a pull-request to the javascript branch?
I'm going to dive into it and add the remaining fields:
From there on only unicorns know! ✨ 🦄
Sounds good, I updated this PR to merge into javascript
.
I can explain my reasons for simplifying the date fields. I think that the strict ISO 8601 dates are a good, universal format to include in the JSON output. In JavaScript they can be parsed with new Date(commit.author_date)
. Or you can use moment: moment(commit.author_date)
. From there you have an extensive API to parse out day, hour, perform timezone conversions, even compute human-friendly relative times. A single, strict ISO 8601 date string has everything you need.
I think the shortest, unqualified name for a given datetime field (for example author_date
) should contain the strict ISO 8601 date. Other JSON fields, such as the ones you mentioned, can definitely be provided, but maybe they should be behind a CLI flag? For example --extra-datetime
to include all the extra, parsed date and time fields or --no-extra-datetime
to exclude them?
Hi, I've got some additional changes that switch from using '--shortstat' to '--numstat' building on top of this.
They are in somewhat rough state right now, but is this something you'd appreciate me polishing up to build on top of this?
This has surely waited too long, but after nearly a year it is here. I should have just have merged it back then. I'm going to keep this in a separate branch for now since even now I haven't gotten around to review anything yet.
I'd very much like to work further on this, but can only do so much at a time. Will hopefully be revisiting this project and its related ones soon - i.e. https://github.com/dreamyguy/gitlogg-api (API) and https://github.com/dreamyguy/gitinsight (Frontend).
I've been making some really big changes. I don't know if you'll want to merge them, but here they are:
xargs
issues.--help
, and--version
--directory
or-d
optionOther changes:
--out
or-o
option.