dreamzmaster / gulp-sitespeedio

Test performance budgets and performance best practice rules using sitespeed.io http://www.sitespeed.io
MIT License
37 stars 14 forks source link

Outdated version of sitespeed.io is creating issues in > node 4.0 #6

Closed Rleahy22 closed 9 years ago

Rleahy22 commented 9 years ago

I ran into issues when trying to move to Node 4.x due to a dependency chain leading to gulp-sitespeedio. This issue does not exist in sitespeed.io at lastest (currently 3.11.1), but gulp-sitespeedio's current version for sitespeed.io is 3.5.0. Updating this dependency would allow for use of Node 4 and later.

For reference:

/Users/{me}/dev/{project}/node_modules/gulp-sitespeedio/node_modules/sitespeed.io/node_modules/browsertime/node_modules/selenium-webdriver/node_modules/ws/node_modules/utf-8-validate
> node-gyp rebuild

  CXX(target) Release/obj.target/validation/src/validation.o
In file included from ../src/validation.cc:15:
../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal'
NAN_INLINE v8::Local<T> _NanEnsureLocal(v8::Local<T> val) {

This is one of many similar errors I see when trying to use Node 4.x