search

dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.
MIT License
359 stars 29 forks source link

Non zero value error #255

Closed marian-code closed 10 months ago

marian-code commented 10 months ago

Hi, after the latest update I'm getting this error when creating a transaction: The value must be more than zero.

I'm on app version 0.3.1-beta+213. Firefly version is 6.1.4 This happens for both withdrawals and deposits for any amount I input. I've tried enabling debug logs but I do not see the error logged there. Other thing I noticed is when I change to non defaut currency I don't get this error.

Anyway thanks for the great work, Iove the app.

thehijacker commented 10 months ago

I have same error when trying to add new transaction. I did see this on Firefly crowdin as new one to translate. Maybe something change on server side and this error might come from Firefly and not internaly from Watefly.

I am using latest Firefly III version 6.1.4.

thehijacker commented 10 months ago

Looking at the Firefly III logs when I submit transaction in Watefly:

03. 01. 2024 10:53:51 [2024-01-03 09:53:51] local.INFO: IsValidPositiveAmount: "0.5" is a valid positive amount.  
03. 01. 2024 10:53:51 [2024-01-03 09:53:51] local.INFO: IsValidPositiveAmount: "0" must be more than zero.

If it helps.

marian-code commented 10 months ago

Probably related to this: firefly-iii/firefly-iii#8328

dreautall commented 10 months ago

Firefly expects now null for the foreign amount field instead of "0". Makes more sense, but I swear null didn't work initially when I coded that part half a year ago.

Anyways, I'll fix it and push a fix asap, sorry for the inconvenience.

dreautall commented 10 months ago

Release is with Google and should hopefully be unlocked soon, alternatively you can sideload the APK already from here.

Thank you for the quick report!

marian-code commented 10 months ago

The updated version is already on play store and I can confirm that it works. Thanks for the fakt solution

thehijacker commented 10 months ago

I too confirm that the latest version correct this issue. Great find and thank you very much for it.