dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.
MIT License
359 stars 29 forks source link

Feature Request: split transactions #325

Open richar120 opened 8 months ago

richar120 commented 8 months ago

Hi, I would like to inquire about split transactions. When dividing a transaction, it would be helpful if Waterfly automatically set the total amount into two by default in the two split transactions. For example:

Original transaction: Purchase $100 Split transaction: First one: Purchase $50 (automatically set the amount) Second one: Empty description $50 (automatically set the amount an also copy the description of the "father transaction")

Later you can change that value if the split is not 50%-50%

Thank you for providing such a great app.

dreautall commented 7 months ago

Hi, sorry for my late response!

I'm not sure if this is a good idea. if you miss-click on the split transaction button and delete it again suddenly the total amount you entered is wrong, and you might not even notice it.

richar120 commented 7 months ago

Hi @dreautall ,

maybe it is important not make the split transaction until the user save the edited movement. If the user cancel the changes, the split transaction will not be reflected on the table of the database, so the transaction will remain as at the beginning.

It is similar to Fintonic, the finance app that i have used until I discovered your app.

Thank you so much for your support!

dreautall commented 7 months ago

Hey,

I don't quite understand how this translates to this issue. Nothing is saved until you hit save in the app, there are no requests happening in the background. Maybe you can explain/reword?

Thank you!

richar120 commented 4 months ago

Hey, sorry for my late response,

I will try to reword this issue.

When splitting a transaction by clicking the "Add Split Transaction" button, the current behavior creates two split transactions: the first with 100% of the original amount and the second with an amount of 0.

I suggest modifying this behavior so that when the "Add Split Transaction" button is pressed, the original amount is divided equally (50/50) between the two split transactions. Users would still be able to adjust the amounts as needed. Additionally, the app should ensure that the sum of the split amounts equals the original transaction amount before allowing the user to save the split transactions.

I hope you will find useful and easy to built,

Thanks in advance,

dreautall commented 4 months ago

Additionally, the app should ensure that the sum of the split amounts equals the original transaction amount before allowing the user to save the split transactions.

That would require a lot of "hidden app logic" the user does really see and might lead to unwanted behavior.

Overall, I'm still with my previous point: if you accidentally press "split transaction" and delete it again, the total sum suddenly changes - or I'm overwriting it with a previous stored value, which might not be valid anymore depending on what the user is editing before noticing the mistake. Saving stuff behind the scenes to reset some fields at a later point is not a good UX behavior :(