search

dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.
MIT License
334 stars 26 forks source link

Show tags on transaction screen #359

Closed tiltshiftfocus closed 5 months ago

tiltshiftfocus commented 5 months ago

As a Spendee user, I was used to using tags and seeing the tags on the main transaction screen. Therefore, I have updated the transaction screen on Waterfly III to show the tags. Hopefully it can be merged.

Below is a screenshot reference of the updated screen.

Screenshot_20240413-203456_Waterfly III

dreautall commented 5 months ago

Hi,

Thank you very much for the PR! I'll have a detailed look during the next week.

I changed the PR to go against the develop branch, not the main branch.

Having a quick look at the code I'll might add some small tweaks to be like the code style used everywhere else (no empty() for list initialization etc, small tweaks).

Do you have tested this with many tags and/or long tags?

Thank you!

tiltshiftfocus commented 5 months ago

Hi there @dreautall,

Thank you for your response.

My sincere apologies, I felt this PR was rather abrupt from me. Furthermore, I really just cloned the repo and went straight into the transaction screen part, neglecting the global code style..

I have tested this code with many tags and it wraps perfectly. However I just tested it on a long tag name after your response (which I should have done so before this PR) and it overflowed. I already have the fix ready by using a Flexible and RichText widget but I am not sure how I should create a PR on this latest change now.

Here's the screenshot reference with the latest fix from me: Screenshot_20240414-023740_Waterfly III

dreautall commented 5 months ago

hey, you should be able to just update this PR with the latest changes. if not, feel free to open a new PR (against the develop branch ideally), and close this one!