search

dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.
MIT License
329 stars 25 forks source link

Transaction list after edit lost group by date #379

Closed BoGnY closed 2 months ago

BoGnY commented 3 months ago

When I edit a transaction, after saving, the transactions list will be reloaded.

Sometimes, not every time, the transactions list lost all group by date...

This is how should be: photo_2024-05-17_10-01-58

This is how is bugged: photo_2024-05-17_10-02-08

Same list, but all dates are disappear 😄

dreautall commented 3 months ago

Oh well, one of the nice "sometimes, sometimes not" category 😄

Does this happen when the list reloads or when it doesn't reload after editing a transaction?

Thank you for the report!

BoGnY commented 3 months ago

🤣🤣

after the reload... after saving edit, reload is done every time, but the result changes sometimes 😅

BoGnY commented 3 months ago

I have an update... the grouping by is lost for the latest transactions, if I scroll down the other transactions are grouped... it seems that (more or less) only the last 10 transactions, or the last week's transactions lose groups it by...

dreautall commented 2 months ago

Unfortunately, the app does not really know how the Firefly API is going to reorder the results of the transaction list once you edit a transaction, and everything else might mess up the pagination...

But the app now tries to make a guess: Only when you add a new transaction or if the date has been changed (which WILL change the sort order), the list is refreshed.

BoGnY commented 2 months ago

ok, in case I investigate more and I open an issue on firefly repo 👍🏻

dreautall commented 2 months ago

Sorry maybe I worded it a bit strange - issue was fixed here as good as I can - Firefly itself is doing nothing wrong, no need for an issue. Update should be out soon :)

BoGnY commented 2 months ago

Sorry, I explained myself badly.. I meant that if there is a problem with the sorting and group by performed by the firefly API, I will open an issue there... If the group by is performed by the firefly API, and is occasionally lost, there is probably a problem there..

Somewhere the group by is executed, and if you say that it is not your app that executes it, but it is the firefly API, it means that the firefly API requires investigation 😄

I'll turn on debugging and try to figure out what causes group by to be lost in some cases