fix(feature/77): use CronetClient instance for auth request

dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.

MIT License

329 stars 25 forks source link

fix(feature/77): use CronetClient instance for auth request #392

Closed j1mbl3s closed 3 months ago

j1mbl3s commented 3 months ago

This PR fixes a misconfigured HTTP request during the initial auth check, as well as removes the custom SSLHttpOverrides class. Additional refactoring of the manifest for readability.

This should resolve the base PR issue by accepting user-installed CA certificates on the device.

Tested on my Samsung S22 with a custom 3-tier PKI.

j1mbl3s commented 3 months ago

adding a comment to link #391

dreautall commented 3 months ago

wow, thank you very much for testing it out and fixing the bugs! looks very good :)

j1mbl3s commented 3 months ago

In truth, following the discussion in #388, I had almost the same changes as your branch, minus the cleanup, but it wasn't working. I didn't realize the mistake I had made until I saw and merged with your branch: I put the android:networkSecurityConfig attribute on the wrong element 🤦

Thanks for the app, I love a good, easy-to-use client!