search

dreautall / waterfly-iii

Unofficial Android App for Firefly III, a free and open source personal finance manager.
MIT License
329 stars 25 forks source link

Transaction list of asset account not reloaded when adding/deleting transaction #394

Closed parthux1 closed 2 months ago

parthux1 commented 3 months ago

Version 1.0.4+312

where

In main dashboard > balance sheet > any asset account

action

Adding or deleting a transaction.

expected

I expect the app to show/hide the added/removed transaction.

current

Currently a manual reload is necessary (pulling the list down or re-entering view)

Is this intended? When deleting a transaction deep down the list, it would be great if the list would stay at this position/date once reloaded.

dreautall commented 2 months ago

i'll look into that - usually the list should be completely reloaded once you add, delete, or change the date of a transaction.

dreautall commented 2 months ago

Initial issue fixed, thank you for reporting.

When deleting a transaction deep down the list, it would be great if the list would stay at this position/date once reloaded.

That's unfortunately not really possible. To save on RAM etc., only the visible area of the list is being built, and it is fetched one page (50 items) per time. Due to how the API works, I need to re-fetch the complete transaction list once a TX is added/deleted (as the pagination will have changed) - and the app resets to the first load basically. Even if I would know "it was 20 items down, so xyz pixels", if you are on page 5, it would show 5 loading animations for you...

Only non-pagination affecting changes (everything but adding, deleting, or changing the date) are able to be done "live" without a refresh unfortunately.

parthux1 commented 2 months ago

Okay. Thank you very much for the explanation and your work in general!