Fixed bug with resolver threads causing the resolver to wait 60 seconds ...

dreedyman / Rio

Rio is an open source technology that provides a dynamic architecture for developing, deploying and managing distributed systems composed of services.

Apache License 2.0

21 stars 17 forks source link

Fixed bug with resolver threads causing the resolver to wait 60 seconds ... #36

Closed rafalkrupinski closed 11 years ago

rafalkrupinski commented 11 years ago

...after being used and keeping the client unnecessarily alive. Threads switched to daemons.

dreedyman commented 11 years ago

As is this modification can not be accepted. Firstly, the resolverExecutor property should be final; secondly, I do not see the reason to change the ExecutorService from a Cached Thread Pool to a Scheduled Thread Pool.

I have made changes to the Rio-M4 branch to create damon threads for a cached thread pool in the AetherResolver class.

rafalkrupinski commented 11 years ago

Glad we could help