msm8916 support: paella

dreemurrs-embedded / Jumpdrive

Flash/Rescue SD Card image for PinePhone and PineTab. This is NOT a bootloader

GNU General Public License v2.0

479 stars 59 forks source link

msm8916 support: paella #54

Closed provokateurin closed 1 year ago

provokateurin commented 3 years ago

Panels are broken on msm8916 and need to be loaded as module. I had to implement that first. Also the mdev setup was not correct and gave me some problems, but that is now fixed too.

Cc @minecrell @calebccff

provokateurin commented 3 years ago

IMG_20210711_154739

calebccff commented 3 years ago

This is super awesome!

provokateurin commented 3 years ago

@MartijnBraam this is done. still anything you would like to have changed?

provokateurin commented 3 years ago

in a clean env everything worked except the librem5 u-boot build, but that failed because of something else

provokateurin commented 3 years ago

@Danct12 @MartijnBraam anything missing?

calebccff commented 3 years ago

Hey, a few notes:

Drop 0bd0200c7426ad61f6f9acdb829a8b8b0f0bdc4e, it's not relevant to the PR and is just subjective pretifying, easier to get this merged without it.
Drop 0bd0200c7426ad61f6f9acdb829a8b8b0f0bdc4e for the same reason, users aren't running this makefile.
It is probably worth fixing the panel driver to work as a builtin, most likely some dependency isn't properly registered in DT and the probe order is wrong. Should be ok as long as mdev doesn't impact the pinephone.
Please squash commits, maybe have one for the README, one to add paella and one to add module loading / mdev.

provokateurin commented 3 years ago

The commit you reference is not pretyfying, but it's needed to build, because the name of the targets changed due to the modules. Try building for pinephone with the previous commit, it won't work. As I'm not developing msm8916 I don't know what the problem with the builtin panel driver is and people like @minecrell know more. Yeah I'll squash the commits.

stephan-gh commented 3 years ago

It is probably worth fixing the panel driver to work as a builtin, most likely some dependency isn't properly registered in DT and the probe order is wrong. Should be ok as long as mdev doesn't impact the pinephone.

I suspect this is some complicated clock driver issue which honestly is not worth investigating at the moment unless you have too much time.