search

dreemurrs-embedded / Pine64-Arch

:penguin: Arch Linux ARM for your PinePhone/Pro and PineTab/2
706 stars 107 forks source link

danctnix: osmin: new pkgbuild #516

Open emulti opened 1 year ago

emulti commented 1 year ago

PKGBUILD for Osmin (GPS Navigator On-Road/Off-Road for Android and Linux devices) Upstream URL https://github.com/janbar/osmin Uses offline maps derived from OpenStreetMap Tested on Pinephone 1.2. Moderate resource and dependency requirements. Uses Geoclue Agent for position determination.

Danct12 commented 1 year ago

Please change commit name to pkg: danctnix: osmin: new pkgbuild. Thanks.

Danct12 commented 1 year ago

That is not what I meant by commit name. You're changing the pull request name, not the commit name.

emulti commented 1 year ago

Sorry for delay, was without internet for a day Commit message now changed, do I need to make a new PR or does it migrate to the existing one?

DrRac27 commented 1 year ago

You didn't change the commit message, you added another commit. You have to create new commits and force-push them to your branch. First you have to use git reset HEAD~2 to checkout the commit 2 commits before HEAD (where you are now). With git reset your changes are like never committed. So now you just git add and git commit with the right commit message like you did before. In git log and git show you can check if you did it right. Then you use git push --force to upload your new changes and delete the old commits from github.

emulti commented 1 year ago

@DrRac27 thank you for the guide. Hopefully it is now correct.

Danct12 commented 1 year ago

LGTM (untested)

mikeshenson commented 1 year ago

I tested this and it worked for me. Device: PinePhone OS: Arch Linux Arm with Phosh Kernel: Linux danctnix 6.1.9-1-danctnix

AgentSmith0 commented 1 year ago

When is this getting merged?

AgentSmith0 commented 1 year ago

@Danct12 Why not merging this? osmin works really well with GPS on the PinePhone (Pro)...

mikeshenson commented 10 months ago

The version is obsolete. Also, there is now a PKGBUILD in the AUR[1]

[1] https://aur.archlinux.org/packages/osmin