search

dreemurrs-embedded / Pine64-Arch

:penguin: Arch Linux ARM for your PinePhone/Pro and PineTab/2
701 stars 104 forks source link

Revert "usb: quirks: Add USB_QUIRK_RESET for Quectel EG25G Modem" #523

Closed Shatur closed 1 year ago

Shatur commented 1 year ago

Steps to reproduce

Run sudo systemctl suspend and wake up the phone by pressing the power button.

Expected behavior

Modem is available.

Actual behavior

Modem reappears in ~10 seconds.

Other distros

The issue was fixed in other distros such as Mobian by reverting the quirk. I think we should do it as well.

Temporary workaround without recompiling the kernel

Just add usbcore.quirks=2c7c:0125:e to the kernel boot parameters in boot/boot.txt and run sudo ./mksrc.

Shatur commented 1 year ago

Even though the modem stops to disappear, a message from qmi about incoming call from suspend may be lost upon waking up. So there is additional patch that is required for PPP: usb-serial-option-add-reset-resume-callback-for-WWAN. I compiled the kernel with this patch and can confirm that it fixes the issue. Please, add this patch too. Was suggested by @biktorgj.

bobjrsenior commented 1 year ago

So there is additional patch that is required for PPP: usb-serial-option-add-reset-resume-callback-for-WWAN.

The patch location was moved in a recent commit. It's now here: https://salsa.debian.org/Mobian-team/devices/kernels/rockchip-linux/-/blob/mobian-6.1/debian/patches/common/0010-usb-serial-option-add-reset-resume-callback-for-WWAN.patch

bobjrsenior commented 1 year ago

Looks like the requested changes were added in this commit: https://github.com/dreemurrs-embedded/Pine64-Arch/commit/00247b8918753c4a89dfab50f656edb63f927984

I installed the latest changes and everything seems to be working so far. The modem is appearing right away when waking from suspend.

Shatur commented 1 year ago

Was fixed, the problem no longer appears.