dreipol / django-scarface

Send push notifications to mobile devices using Amazon SNS
MIT License
43 stars 21 forks source link

Message Trimming #4

Closed philipplaeubli closed 8 years ago

philipplaeubli commented 9 years ago

The current trim treshold too small. The best thing would probably be to remove the trimming anyway (or to add a warning).

Dealers commented 9 years ago

Thanks Philipp.

How can I Philipp remove the trimming?

Regards

Uzi Lumbroso

M +972-52-3330506

F +972-9-7710184

uzi@dealers-app.com

Skype: uzport

Logo_(full).png

http://www.dealers-app.com/ www.dealers-app.com

The information contained in this document is proprietary of Dealers©. It contains confidential or privileged information, and is intended only for the use of the intended addressee thereof. If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited. If you receive this document or communication in error, please return it to Dealers© and delete it from your computer. Thank you.

P Please consider the environment before printing this email

From: Philipp Läubli [mailto:notifications@github.com] Sent: Tuesday, April 21, 2015 12:41 PM To: dreipol/django-scarface Subject: [django-scarface] Message Trimming (#4)

The current trim treshold too small. The best thing would probably be to remove the trimming anyway (or to add a warning).

— Reply to this email directly or view it on GitHub https://github.com/dreipol/django-scarface/issues/4 . https://github.com/notifications/beacon/AFtSy8D5HWK8OGjp16Q0RxwCr7onA52Jks5oBhKdgaJpZM4EFA_F.gif

melbic commented 9 years ago

Please notice, that there still is a maximum payload length for push message. For APNS prior iOS 8 it was 256 bytes, in iOS 8 and later it is 2 kBytes. (https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/ApplePushService.html#//apple_ref/doc/uid/TP40008194-CH100-SW1) For GCM I didn't check yet.

philipplaeubli commented 9 years ago

True, and also related: http://aws.amazon.com/about-aws/whats-new/2013/06/18/amazon-sqs-announces-256KB-large-payloads/

melbic commented 9 years ago

@Dealers The method is called trim_message and is in models.py.

Dealers commented 9 years ago

Thanks.

נשלח מה-iPhone שלי

‫ב-27 באפר׳ 2015, בשעה 09:47, ‏‏Samuel Bichsel ‏notifications@github.com כתב/ה:‬

@Dealers The method is called trim_message and is in the models.py.

— Reply to this email directly or view it on GitHub.

philipplaeubli commented 8 years ago

Fixed with c99ef2b