search

dremio / dbt-dremio

dbt (data build tool) adapter for the Dremio
Apache License 2.0
44 stars 21 forks source link

Make fetch configurable and fix hook tests #204

Closed ravjotbrar closed 1 year ago

ravjotbrar commented 1 year ago

Summary

Fix provided by @Conq1. Before this change, execution time was idling even after the job was finished in Dremio. This was happening because the adapter would fetch unnecessary data from the materialized model.

Description

This change makes it so the adapter only fetches data from the materialized model if fetch is set to true.

Test Results

All tests pass

Changelog

Related Issue

https://github.com/dremio/dbt-dremio/issues/176

Conq1 commented 1 year ago

Except for the test I see you just copied my code. Glad you approve. :) Anyways. Nice to see this project having some activity. Unfortunately haven't had much time to work with Dremio for a few months now, but will hopefully change soon.

ravjotbrar commented 1 year ago

Apologies @Conq1. It was remiss of me to not give you credit for the fix. Added a line to the summary.