search

dren-dk / HunspellJNA

Hunspell library for Java based on JNA
GNU Lesser General Public License v3.0
62 stars 39 forks source link

add HunspellJNA to Maven Central #2

Open thomas-joiner opened 12 years ago

thomas-joiner commented 12 years ago

I would be obliged if you would add HunspellJNA to Maven Central.

Sonatype has a guide on how to accomplish this.

I also created a test pom file which I used to install it to my local repository. You may or may not want to change the <artifactId> and the <version> as I came up with those fairly arbitrarily. I believe that the rest of the information should be correct.

rquinio commented 12 years ago

I would appreciate this as well !

thomas-joiner commented 11 years ago

@rquinio

As this didn't appear that it would have any progress made on it, I went ahead and made my own library (HunspellBridJ) and got it in the central repository. The interface is not the exact same as HunspellJNA (it takes a more object-oriented approach to it), however it does expose all of the functions exposed by hunspell's C API (for whatever reason, I couldn't get BridJ to properly interface with the C++).

Its coordinates are:

<dependency>
    <groupId>com.atlascopco</groupId>
    <artifactId>hunspell-bridj</artifactId>
    <version>1.0.0</version>
</dependency>

Hope this helps someone else.

dren-dk commented 11 years ago

On Mon, Feb 4, 2013 at 3:36 PM, Thomas Joiner notifications@github.comwrote:

@rquini https://github.com/rquinio

As this didn't appear that it would have any progress made on it, I went ahead and made my own library (HunspellBridJhttps://github.com/thomas-joiner/HunspellBridJ) and got it in the central repository.

You could also have sent me a pull request with the needed changes, thus sparing the world yet another fork of this project.

Flemming Frandsen - YAPH - http://osaa.dk - http://dren.dk/

thomas-joiner commented 11 years ago

This is not something that could be accomplished through a pull request. It required you to go to Sonatype, make an account, and submit it to Maven Central. I created an example POM that you probably could have used wholesale (unless you decided you wanted a different groupId, artifactId, or version). I linked you to the directions that specify exactly what you need to do to get something into Maven Central. I opened this issue 6 months ago.

The features added were added because I felt that if I was going to create bindings for it, then I should allow access to all of the functions. If I had needed them, and that was the reason that I created the new library, then I would have just sent you a pull request.

Also, this is not a fork. This uses BridJ to create the bindings, not JNA. This has the pro of not requiring someone to add JNA if they only use BridJ in their current setup. (And of course the con of requiring someone to add BridJ if they only use JNA in their current setup.) BridJ itself has various pros and cons concerning JNA, which you can read about at the project site if you so wish.

pot0to commented 7 years ago

Hi, I was wondering if this is still being worked on? I saw PR #8 had been merged, but I'm unfamiliar with how much work it involves to get something into Maven Central.