search

drenther / upi_pay

Flutter plugin for UPI (Only in India)
MIT License
58 stars 71 forks source link

iOS support, support for more apps, measures for ensuring production and experimentation modes #17

Closed reeteshranjan closed 3 years ago

reeteshranjan commented 3 years ago

Support for several apps added including verification of end-to-end working.

Apps found by searching for "BHIM" and "UPI" on play store and app store and also from these links:

https://www.upichalega.com/upi-partners.php https://www.npci.org.in/upi-PSP&3rdpartyApps https://www.npci.org.in/upi-live-members https://www.sebi.gov.in/sebiweb/other/OtherAction.do?doRecognisedFpi=yes&intmId=43

[Part of work to resolve issue #15]

reeteshranjan commented 3 years ago

Testing done: ran the upi_pay example on an Android device and verified that all installed UPI apps got detected.

upi-pay-example-run

drenther commented 3 years ago

@pepsighan Should we remove support for MiPay, AirtelPay and Truecaller? And bump this into a major version.

drenther commented 3 years ago

Hey @reeteshranjan What's you call on fixing the MiPay package Id i.e. having both the packages id added in this PR? Since, it will expanding the supported apps. It makes sense to have MiPay fiasco handled in as well.

reeteshranjan commented 3 years ago

Hey @reeteshranjan What's you call on fixing the MiPay package Id i.e. having both the packages id added in this PR? Since, it will expanding the supported apps. It makes sense to have MiPay fiasco handled in as well.

Yes will add a commit to include both package IDs. Have seen all discussion around the 2 MiPay packages.

reeteshranjan commented 3 years ago

@drenther do you plan to merge this pull request? If not, it is OK if I submit this work as a new plugin with upi_pay duly credited and referenced? The point is that I want the work to reach in hands of more developers.

drenther commented 3 years ago

I did not know of this PR being completed. I thought it was still WIP.

If you want I can move this package to a org and bring you in as a member in it. That way the community doesn't fragment and it comes under a platform where others can join in more easily.

Let me know what you think.

reeteshranjan commented 3 years ago

I did not know of this PR being completed. I thought it was still WIP.

If you want I can move this package to a org and bring you in as a member in it. That way the community doesn't fragment and it comes under a platform where others can join in more easily.

Let me know what you think.

I did not get that you need more information to know that this is not WIP; because there is no movement on any of my comments across all the relevant issues, so thought this package's development is not in your priority right now. Typically, I would expect some activity from package owners after updates in pull request and comments across relevant issues which could tell me either way - the package is looking for merges, or not.

Could you please look at all the changes and push any review comments out, so I know if this pull request is ready to merge or you expect any more changes?

drenther commented 3 years ago

Sure will do. Overall the PR looks good to me. But the changes are quite massive and deviate a lot from what the initial package was. Since you made the massive effort of going through this effort. Would you like to be involved with maintaining the project. If you do I have already sent an invite to this repo and will add you as a publisher in pub.dev the same.

reeteshranjan commented 3 years ago

Sure will do. Overall the PR looks good to me. But the changes are quite massive and deviate a lot from what the initial package was. Since you made the massive effort of going through this effort. Would you like to be involved with maintaining the project. If you do I have already sent an invite to this repo and will add you as a publisher in pub.dev the same.

Sure I'll be more than happy to maintain the package and continue the work like done in this PR. I'm very close to testing UPI merchant payments next, which will be my next PR that should stabilise this package's utility and bring lot of clarity to all the users.

Accepted the invite. Thanks for inviting me!

drenther commented 3 years ago

Glad to have you onboard. I wasn't active for personal reasons and would highly appreciate the help here. I have sent a typo filled mail on the email I found on your profile to ask for your pub.dev details to invite you as a publisher.

reeteshranjan commented 3 years ago

@drenther do you have any further process remaining to go before merging this PR?

drenther commented 3 years ago

Looks good to me. May be we will do a docs revamp later. But I don't think this PR needs to remain open for that. Please go ahead and merge.

reeteshranjan commented 3 years ago

Looks good to me. May be we will do a docs revamp later. But I don't think this PR needs to remain open for that. Please go ahead and merge.

OK. Just in case you have not looked at the new README.md (it's completely revamped with more information about the UPI related findings etc.) and the new APPS.md with apps information, then please look at it. I did that work to get the documentation in sync with where the work on functionality in this PR has reached.

drenther commented 3 years ago

Yea the README and it looks great and gives all the setup you need to use it in either case.

I was just referring to may be a doc site in future. Hence, I said I see no reason for the PR to stay open the README is all in sync.

reeteshranjan commented 3 years ago

Yea the README and it looks great and gives all the setup you need to use it in either case.

I was just referring to may be a doc site in future. Hence, I said I see no reason for the PR to stay open the README is all in sync.

OK. Not sure how the API doc sites get built; but I did improve the dartdoc comments documentation and generated the documentation using dartdoc. It's in doc/ folder that got added with this. If that's what will create the API docs, then we have that covered, too.

drenther commented 3 years ago

Thanks again for this behemoth of a PR and the massive effort and patience on this!